fix(sdk): initialize sandbox annotations#2297
Closed
pimlock wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
pimlock
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
July 15, 2026 15:07
Collaborator
Author
|
Too late :) #2296 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Rust check failure on
mainby initializing protobuf annotation maps in the newly added SDK request builder and test fixture.Related Issue
No issue. Fixes the failing main branch Rust job.
Changes
CreateSandboxRequest.annotationsin the high-level SDK request builder.ObjectMeta.annotationsin the SDK mock sandbox fixture.Testing
mise run pre-commitpassesChecklist